761569 - Failure in testCloseWindow | can't access dead object

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Comment 1

[Remus Pop (:RemusPop)]

This happens in Nightly on Mac OSX.
Copying over the comment with what was tried towards finding the problematic lines in the test:

After this line I inserted a sleep(2000).
http://hg.mozilla.org/qa/mozmill-tests/file/73b913d2b1f4/tests/functional/testPrivateBrowsing/testCloseWindow.js#l87

The failure complains about a new elementslib when executing this._view = _document.defaultView;
So I think the DOM is not ready when executing line 88: var tab = controller.tabs.getTab(i);

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We would have to recreate the controller and tabBrowser instance because they would operate on a window which already has been closed.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

The problem we are facing here is that controller.tabs.getTab() is broken and returns a document which defaultView is not valid anymore. This is most likely a Mozmill bug which I will file tomorrow.

Thankfully we can make use of controller.tabs.activeTab here so we can workaround the problem.

This patch fixes this issue and also makes the code a bit cleaner.

Comment 4

[u279076]

Comment on attachment 630768 [details] [diff] [review]
Patch v1

Review of attachment 630768 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks fine to me.

Comment 5

[Remus Pop (:RemusPop)]

Comment on attachment 630768 [details] [diff] [review]
Patch v1

Looks good and works fine. Great for finding such a simple fix.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Pushed to default for now:
http://hg.mozilla.org/qa/mozmill-tests/rev/4776b926c148

If we pass now I can backport to aurora later.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Tests for Nightly builds don't show this failure anymore. Pushed patch to all older branches due to improvements of stability:

http://hg.mozilla.org/qa/mozmill-tests/rev/e6ca41d437d5 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/f323d63f3db5 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/057e6dea86ba (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/33d2c0559cf2 (esr10)